dsuhinin commented on code in PR #63180: URL: https://github.com/apache/airflow/pull/63180#discussion_r2995278151
########## airflow-core/src/airflow/api_fastapi/core_api/routes/public/log.py: ########## @@ -59,6 +62,19 @@ } +def _batched_ndjson_stream( Review Comment: > @dsuhinin I would suggest renaming the method to something like `_buffered_ndjson_stream` because batch suggests that a timer is involved. Also, can you add some simple unit tests to avoid confusion on how it works? sure. thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
