vamsi2246 commented on code in PR #64267:
URL: https://github.com/apache/airflow/pull/64267#discussion_r3005215289
##########
airflow-core/src/airflow/ui/src/pages/Dashboard/Stats/PluginImportErrors.tsx:
##########
@@ -38,42 +38,47 @@ export const PluginImportErrors = ({ iconOnly = false }: {
readonly iconOnly?: b
const importErrors = data?.import_errors ?? [];
if (isLoading) {
- return <Skeleton height="9" width="225px" />;
+ return iconOnly ? (
+ <Skeleton height="7" width="60px" />
+ ) : (
+ <Skeleton height="42px" width="175px" />
Review Comment:
Good catch! I've updated the skeleton `height` from `"7"` (Chakra spacing
scale) to `"28px"` so all dimensions use consistent `px` values. Also added
comments explaining where each value comes from:
- `iconOnly`: `28px × 60px` — matches the rendered `StateBadge`
(`height={7}` = 28px in Chakra's spacing scale)
- `full`: `42px × 175px` — matches the rendered `StatsCard` dimensions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
