jscheffl commented on code in PR #64135: URL: https://github.com/apache/airflow/pull/64135#discussion_r3005416974
########## chart/values.yaml: ########## @@ -498,19 +498,14 @@ extraEnvFrom: ~ # Airflow database & redis config data: - # If secret names are provided, use those secrets - # These secrets must be created manually, eg: - # - # kind: Secret - # apiVersion: v1 - # metadata: - # name: custom-airflow-metadata-secret - # type: Opaque - # data: - # connection: base64_encoded_connection_string - + # Must contain a 'connection' key (e.g., postgresql://user:pass@host:5432/db). + # Optional: 'kedaConnection'. Note: URL-encode special characters in passwords. Review Comment: I am not sure if and why your description is now better than the example before. The example before which you now are removing had an example. Yes it was not mentioning that the `connection` key is needed. I'd favor keeping the example and marking the note that key(s) are needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
