deepujain commented on PR #64375:
URL: https://github.com/apache/airflow/pull/64375#issuecomment-4151447121
Redid this on `v2-11-test` as requested and kept the same PR thread.
What changed in the redo:
- I force-pushed the branch rebased onto `v2-11-test` and changed the PR
base from `main` to `v2-11-test`.
- The fix is now applied to the 2.11 branch paths
(`airflow/providers/fab/...` and `tests/providers/fab/...`) instead of the
`main`-branch provider layout.
- The branch-local file checks passed after the port:
- `ruff check
airflow/providers/fab/auth_manager/cli_commands/user_command.py
tests/providers/fab/auth_manager/cli_commands/test_user_command.py`
- `ruff format --check
airflow/providers/fab/auth_manager/cli_commands/user_command.py
tests/providers/fab/auth_manager/cli_commands/test_user_command.py`
Validation note:
- I also attempted the requested real-environment validation with `uv tool
install -e ./dev/breeze --force` followed by `breeze start-airflow ...`, but
the run is currently blocked on this machine because Docker is not running
(`Cannot connect to the Docker daemon at
unix:///Users/dejain/.docker/run/docker.sock`).
- I attempted the targeted branch-local pytest path as well, but local DB
initialization on this machine is currently failing in `v2-11-test` with a
SQLite migration error unrelated to this FAB CLI change (`foreign key mismatch
- "deadline_alert" referencing "serialized_dag"`).
So the PR is now redone on the correct target branch, and I will rerun the
Breeze validation as soon as Docker is available.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
