wjddn279 commented on code in PR #64143:
URL: https://github.com/apache/airflow/pull/64143#discussion_r3007378662
##########
providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/kube_config.py:
##########
@@ -49,7 +49,7 @@ def __init__(self, executor_conf: ExecutorConf | None = None):
self.airflow_home = AIRFLOW_HOME
self.dags_folder = self._conf.get(self.core_section, "dags_folder")
self.parallelism = self._conf.getint(self.core_section, "parallelism")
- self.pod_template_file = self._conf.get(self.kubernetes_section,
"pod_template_file", fallback=None)
+ self.pod_template_file = self._conf.get(self.kubernetes_section,
"pod_template_file", fallback="")
Review Comment:
After testing, I found that when the fallback is triggered and the value is
None, it causes an error in the tests. It's this part.
https://github.com/apache/airflow/blob/6d8ccc687b64aca6841e5c9976799be9c364345c/providers/cncf/kubernetes/src/airflow/providers/cncf/kubernetes/cli/kubernetes_command.py#L109
This PR (https://github.com/apache/airflow/pull/64209) likely eliminates
the case where the fallback is triggered in test, but you can think of this
change as a fix for the case where None is passed in and causes an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
