cruseakshay commented on code in PR #62867:
URL: https://github.com/apache/airflow/pull/62867#discussion_r3007552785
##########
providers/common/sql/src/airflow/providers/common/sql/datafusion/object_storage_provider.py:
##########
@@ -70,12 +70,78 @@ def get_scheme(self) -> str:
return "file://"
+class GCSObjectStorageProvider(ObjectStorageProvider):
+ """GCS Object Storage Provider using DataFusion's GoogleCloud."""
+
+ @property
+ def get_storage_type(self) -> StorageType:
+ """Return the storage type."""
+ return StorageType.GCS
+
+ def create_object_store(self, path: str, connection_config:
ConnectionConfig | None = None):
+ """Create a GCS object store using DataFusion's GoogleCloud."""
+ if connection_config is None:
+ raise ValueError(f"connection_config must be provided for
{self.get_storage_type}")
+
+ try:
+ from airflow.providers.google.common.hooks.base_google import
GoogleBaseHook
+
+ bucket = self.get_bucket(path)
Review Comment:
Done, added
`credential_config_file` (file path): passed as `service_account_path`
`credential_config_file` (inline JSON string or dict): written to a temp
file and passed to service_account_path
Explicitly rejected:
`key_secret_name` raises `ObjectStoreCreationException` with a clear message.
Regression test also added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
