amoghrajesh commented on code in PR #64209:
URL: https://github.com/apache/airflow/pull/64209#discussion_r3007703123
##########
shared/configuration/src/airflow_shared/configuration/parser.py:
##########
@@ -339,20 +402,25 @@ def get_from_provider_cfg_config_fallback_defaults(self,
section: str, key: str,
section, key, fallback=None, raw=raw, vars=vars_
)
Review Comment:
The fallback is None here, should we change that too?
##########
airflow-core/src/airflow/providers_manager.py:
##########
@@ -1455,10 +1451,6 @@ def provider_configs(self) -> list[tuple[str, dict[str,
Any]]]:
self.initialize_providers_configuration()
return sorted(self._provider_configs.items(), key=lambda x: x[0])
- @property
- def already_initialized_provider_configs(self) -> list[tuple[str,
dict[str, Any]]]:
- return sorted(self._provider_configs.items(), key=lambda x: x[0])
Review Comment:
Compat here too please.
##########
shared/configuration/src/airflow_shared/configuration/parser.py:
##########
@@ -438,7 +505,9 @@ def __init__(
)
self._suppress_future_warnings = False
self.upgraded_values: dict[tuple[str, str], str] = {}
- self._providers_configuration_loaded = False
+ # The _use_providers_configuration flag will always be True unless we
call `write(include_providers=False)` or `with
self.make_sure_configuration_loaded(with_providers=False)`.
+ # Even we call those methods, the flag will be set back to True after
the method is done, so it only affects the current call to `as_dict()` and does
not have any effect on subsequent calls.
Review Comment:
```suggestion
# The _use_providers_configuration flag will always be True unless
we call
`write(include_providers=False)` or `with
self.make_sure_configuration_loaded(with_providers=False)`.
# Even when we call those methods, the flag will be set back to True
after the method is done, so it only affects the current call to `as_dict()`
and does not have any effect on subsequent calls.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
