amoghrajesh commented on code in PR #62709:
URL: https://github.com/apache/airflow/pull/62709#discussion_r3008587317
##########
airflow-core/src/airflow/partition_mappers/temporal.py:
##########
@@ -30,14 +34,23 @@ class _BaseTemporalMapper(PartitionMapper, ABC):
def __init__(
self,
+ *,
Review Comment:
This change makes `input_format` and `output_format` keyword only, will this
be an issue for users using `ToHourlyMapper` or other mappers without kw only
params? Like `ToHourlyMapper("%Y-%m-%dT%H:%M:%S")`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
