Vegapunk-debug opened a new pull request, #64498:
URL: https://github.com/apache/airflow/pull/64498

   ### closes: None (No related issue)
   
   ---
   ### Description
   **This PR addresses transaction overhead and technical debt during `airflow 
variables import` and `airflow connections import` CLI operations.**
   
   Previously, importing 1000 items from a CLI file would unnecessarily 
initiate 1000 standalone transactions because `Variable.set` internally 
defaults to provisioning its own session if not provided, and 
`connections_import` explicitly used `session.commit()` inside its for-loop 
scope.
   
   * `variable_command.py`: Properly accepts `session` strictly as a 
keyword-only argument (`*, session=NEW_SESSION`) and pipes it down to 
`Variable.set(..., session=session)` within the data loop.
   * `connection_command.py`: Eliminates explicit iteration limits 
`session.commit()` in `_import_helper`. Uses the implicit auto-commit properly 
handled at the exit of `with create_session() as session`.
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [ ] Yes (please specify the tool below)
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to