shivaam commented on PR #62561:
URL: https://github.com/apache/airflow/pull/62561#issuecomment-4162163633

   > this seems like a "good enough" fix so i have no problem merging it.
   > 
   > but...
   > 
   > i can think of some things that might be robust that maybe it would make 
sense to create a followup issue for and cross reference it (reference the 
issue in the comment, reference the comment / code location in the issue)
   > 
   > so basically idea #1 is, we could create wrap the entire backcfill 
creation logic in a transaction, so that the record isn't actually there til 
the backfill creation process is complete.
   > 
   > idea #2 is, use datetimes or a state field to indicate whether the 
backfill is still being created. like, add field like "started_at" or 
"queued_at" or something to Backfill record, and this could be null until the 
backfill is fully created.
   > 
   > all of these options may have their own problems and tradeoffs so for now 
LGTM
   
   Created a follow up issue:
   https://github.com/apache/airflow/issues/64534


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to