bhavya2109sharma opened a new pull request, #64545:
URL: https://github.com/apache/airflow/pull/64545

   **Description**
   ------
   Add two new operators to the Amazon SageMaker provider:
   
   - SageMakerConditionOperator: Branch operator mirroring SageMaker Pipelines 
ConditionStep. Supports flat params (condition_type/left/right) for simple 
conditions and conditions list for Not/Or composition.
   
   - SageMakerFailOperator: Terminal operator mirroring SageMaker Pipelines 
FailStep. Raises AirflowFailException with user-defined error message,skipping 
retries. It will log a structured message before raising the exception, making 
it immediately clear in task logs that the failure was a deliberate workflow 
decision, not an unexpected crash
   
   **Usage**
   -------
   Simple condition (flat interface):
   ```
   check = SageMakerConditionOperator(
       task_id="check_accuracy",
       condition_type="GreaterThanOrEqualTo",
       left="{{ ti.xcom_pull(task_ids='evaluate')['accuracy'] }}",
       right=0.9,
       if_task_ids=["deploy"],
       else_task_ids=["retrain"],
   )
   ```
   
   Multiple AND-ed conditions with Or/Not composition:
   ```
   check = SageMakerConditionOperator(
       task_id="check",
       conditions=[
           {"type": "GreaterThanOrEqualTo", "left": "{{ ... }}", "right": 0.9},
           {"type": "Not", "condition": {"type": "Equals", "left": "{{ ... }}", 
"right": "us-east-1"}},
       ],
       if_task_ids=["deploy"],
       else_task_ids=["retrain"],
   )
   ```
   
   Fail operator:
   ```
   fail = SageMakerFailOperator(
       task_id="fail",
       error_message="Accuracy {{ ti.xcom_pull('evaluate')['accuracy'] }} below 
threshold",
   )
   ```
   
   **Testing**
   ------
   **Unit tests** 
   
    ```
   breeze testing providers-tests --test-type "Providers[amazon]" 
--providers/amazon/tests/unit/amazon/aws/operators/test_sagemaker_condition.py 
providers/amazon/tests/unit/amazon/aws/operators/test_sagemaker_fail.py -xvs
   ```
   **System tests** 
   No AWS credentials or SageMaker resources needed the operator evaluates 
conditions in runtime only.
   ```
   breeze shell 
   pytest 
providers/amazon/tests/system/amazon/aws/example_sagemaker_condition.py 
--system -xvs
   
   ```
   
   Note : No system test for SageMakerFailOperator as this operator raises 
AirflowFailException which marks the task as failed. The system test 
framework's watcher task uses` trigger_rule=ALL_DONE` and treats any failed 
task as a test failure, making it impossible to have a "passing test that 
intentionally fails." Unit tests provide complete coverage.
   
   
   **Documentation**
   ------
   Howto sections added to sagemaker.rst with exampleinclude directives from 
the system test covering:
   - Simple flat interface (single condition)
   - Multiple AND-ed conditions with XCom templates
   - Not and Or logical combinators
   
   
    <!-- SPDX-License-Identifier: Apache-2.0
         https://www.apache.org/licenses/LICENSE-2.0 -->
   
   <!--
   Thank you for contributing!
   
   Please provide above a brief description of the changes made in this pull 
request.
   Write a good git commit message following this guide: 
http://chris.beams.io/posts/git-commit/
   
   Please make sure that your code changes are covered with tests.
   And in case of new features or big changes remember to adjust the 
documentation.
   
   Feel free to ping (in general) for the review if you do not see reaction for 
a few days
   (72 Hours is the minimum reaction time you can expect from volunteers) - we 
sometimes miss notifications.
   
   In case of an existing issue, reference it using one of the following:
   
   * closes: #ISSUE
   * related: #ISSUE
   -->
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change below checkbox to `[X]` followed by the name of the tool, uncomment 
the "Generated-by".
   -->
   
   - [X] Yes (please specify the tool below)
   - Generated-by: [Claude Opus 4.6] following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   
   <!--
   Generated-by: [Tool Name] following [the 
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
   -->
   
   ---
   
   * Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information. Note: commit author/co-author name and email in commits 
become permanently public when merged.
   * For fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   * When adding dependency, check compliance with the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   * For significant user-facing changes create newsfragment: 
`{pr_number}.significant.rst`, in 
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
 You can add this file in a follow-up commit after the PR is created so you 
know the PR number.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to