uranusjr commented on code in PR #64522:
URL: https://github.com/apache/airflow/pull/64522#discussion_r3018925648
##########
airflow-core/src/airflow/models/xcom.py:
##########
@@ -66,6 +67,7 @@ class XComModel(TaskInstanceDependencies):
task_id: Mapped[str] = mapped_column(String(ID_LEN, **COLLATION_ARGS),
nullable=False, primary_key=True)
map_index: Mapped[int] = mapped_column(Integer, primary_key=True,
nullable=False, server_default="-1")
key: Mapped[str] = mapped_column(String(512, **COLLATION_ARGS),
nullable=False, primary_key=True)
+ dag_result: Mapped[bool | None] = mapped_column(Boolean, nullable=True,
default=False)
Review Comment:
This is intentional; we had some serious issue around setting values on
existing rows during migration in 3.2 and I want to avoid that. The XCom table
can be potentially very very big, and it’s not worthwhile to normalise null to
false IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
