shivaam commented on code in PR #64516:
URL: https://github.com/apache/airflow/pull/64516#discussion_r3023067132
##########
dev/breeze/src/airflow_breeze/commands/pr_commands.py:
##########
@@ -2152,6 +2152,9 @@ def _compute_default_action(
elif not has_ci_failures and not has_conflicts and has_unresolved_comments:
# CI passes, no conflicts, no LLM issues — only unresolved review
comments; just add a comment
action = TriageAction.COMMENT
+ elif not has_ci_failures and not has_conflicts and not
has_unresolved_comments:
+ # Only soft violations (e.g. missing UI demo) — just comment, don't
convert to draft
+ action = TriageAction.COMMENT
Review Comment:
Thanks for the feedback. I removed the soft-violations branch in the latest
commit.
One thing to note: with --answer-triage y, there's no way to differentiate
per-check — a PR with only a missing screenshot gets drafted the same as one
with failing CI. That's fine for now since maintainers mostly run
interactively, but worth keeping in mind.
For the future, I'm thinking about a plugin-based approach where each check
defines its own suggested default action alongside its violations:
```
# Each check returns its own suggested action
assess_pr_checks() → ("draft", violations)
assess_pr_ui_demo() → ("comment", violations)
assess_pr_conflicts() → ("draft", violations)
```
Then _compute_default_action just aggregates by picking the most severe:
draft > comment > rerun. No conditional chain needed — it scales to any number
of checks without touching the aggregation logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
