Copilot commented on code in PR #64046:
URL: https://github.com/apache/airflow/pull/64046#discussion_r3025330261
##########
airflow-core/docs/administration-and-deployment/logging-monitoring/metric_tables.rst:
##########
@@ -61,8 +62,14 @@ Name Legacy Name
``triggers.failed`` ``-``
Number of triggers that errored
before they could fire an event
``triggers.succeeded`` ``-``
Number of triggers that have fired at
least one event
``asset.updates`` ``-``
Number of updated assets
-``asset.orphaned`` ``-``
Number of assets marked as orphans
because they are no longer referenced in Dag schedule parameters or task outlets
``asset.triggered_dagruns`` ``-``
Number of Dag runs triggered by an
asset update
+``deadline_alerts.deadline_created`` ``-``
Number of deadline alerts created for
a Dag run
+``deadline_alerts.deadline_missed`` ``-``
Number of deadline alerts that fired
because a Dag run missed its deadline
+``deadline_alerts.deadline_not_missed`` ``-``
Number of deadline records deleted
because the Dag run finished before the deadline
Review Comment:
Capitalization is inconsistent with other entries in this file (e.g., “DAG
file processing runs”). For consistency, consider using “DAG run” instead of
“Dag run” in these new descriptions.
##########
airflow-core/docs/administration-and-deployment/logging-monitoring/metric_tables.rst:
##########
@@ -61,8 +62,14 @@ Name Legacy Name
``triggers.failed`` ``-``
Number of triggers that errored
before they could fire an event
``triggers.succeeded`` ``-``
Number of triggers that have fired at
least one event
``asset.updates`` ``-``
Number of updated assets
-``asset.orphaned`` ``-``
Number of assets marked as orphans
because they are no longer referenced in Dag schedule parameters or task outlets
``asset.triggered_dagruns`` ``-``
Number of Dag runs triggered by an
asset update
+``deadline_alerts.deadline_created`` ``-``
Number of deadline alerts created for
a Dag run
+``deadline_alerts.deadline_missed`` ``-``
Number of deadline alerts that fired
because a Dag run missed its deadline
+``deadline_alerts.deadline_not_missed`` ``-``
Number of deadline records deleted
because the Dag run finished before the deadline
+``ol.emit.failed`` ``-``
Number of failed OpenLineage event
emit attempts
+``edge_worker.heartbeat_count``
``edge_worker.heartbeat_count.{worker_name}`` Number
heartbeats in an edge worker.
Review Comment:
Grammar issue in the description: it’s missing a word. Consider changing to
“Number of heartbeats in an edge worker.” to read correctly.
```suggestion
``edge_worker.heartbeat_count``
``edge_worker.heartbeat_count.{worker_name}`` Number
of heartbeats in an edge worker.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
