Copilot commented on code in PR #64026: URL: https://github.com/apache/airflow/pull/64026#discussion_r3025334283
########## docs/translation_nl_guidelines.md: ########## @@ -0,0 +1,15 @@ +# Dutch (nl) Translation Guidelines + Review Comment: This new Markdown file is missing the ASF license header / SPDX identifier comment that most repository Markdown files include (e.g. `README.md:1-18`). Since CI runs Apache RAT (see `.github/workflows/basic-tests.yml`), this is likely to fail the license header check. Add the standard ASF header (HTML comment) or the SPDX HTML comment used in the existing translation guideline files under `.github/skills/airflow-translations/locales/`. ########## docs/translation_nl_guidelines.md: ########## @@ -0,0 +1,15 @@ +# Dutch (nl) Translation Guidelines + +## Language Rules +- Use simple Dutch language +- Avoid mixing English + +## Tone +- Clear and professional + +## Formatting +- Keep same meaning + +## Example Review Comment: This markdown is likely to fail the repo’s `markdownlint` pre-commit hook (configured in `.pre-commit-config.yaml` as `lint-markdown`) because headings aren’t followed by a blank line before the list/text. For example, `## Language Rules` is immediately followed by `- Use simple Dutch language`, which violates common markdownlint rules like MD022/MD032. Add a blank line after each `## ...` heading before the following list/text block. ```suggestion ## Language Rules - Use simple Dutch language - Avoid mixing English ## Tone - Clear and professional ## Formatting - Keep same meaning ## Example ``` ########## docs/translation_nl_guidelines.md: ########## @@ -0,0 +1,15 @@ +# Dutch (nl) Translation Guidelines + +## Language Rules +- Use simple Dutch language +- Avoid mixing English Review Comment: This guideline file is likely intended to be consumed by the existing UI translation workflow under `.github/skills/airflow-translations/` (see `.github/skills/airflow-translations/SKILL.md:225-247`, which already links to `locales/nl.md`). Adding it under `docs/` means the referenced `nl` guideline remains missing and this new file is likely unused by the translation tooling. Consider moving/renaming this file to `.github/skills/airflow-translations/locales/nl.md` and aligning with the established locale-guideline format there (including the SPDX header used by other locale files, e.g. `.github/skills/airflow-translations/locales/ca.md:1-4`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
