rusher commented on PR #60133: URL: https://github.com/apache/airflow/pull/60133#issuecomment-4178460589
rebased on main branch. this is now simplified, since main now use SQLAlchemy recent version that correct different issues. So to recapitulate : I've separated the changes into 2 differents commit : [[0fe7093](https://github.com/apache/airflow/pull/60133/commits/0fe70939974e9c07b6cdbae34cd8e5c7e840ad9e) ](https://github.com/apache/airflow/pull/60133/commits/b9da4fe819503ff1aad67aa0943da3ac33707d8d) contains the change to make mariadb work this fix contains : * with_row_locks: the with_row_locks function that made sense long time ago is now problematic : MariaDB 10.6+ supports FOR UPDATE, NOWAIT, SKIP LOCKED, and SQLAlchemy support it natively well. The supports_for_update_of check is incorrect for mariadb, since it support all locking features but 'FOR UPDATE OF <table>' * Migration 0036: Fixed error 1093 by wrapping subquery in derived table for MariaDB * Migration 0049: Added MariaDB-specific REGEXP_REPLACE syntax (3-arg PCRE2 vs MySQL 8's 6-arg) * scheduler_job_runner.py: disable RETURNING clause because unused, and problematic in MariaDB (RETUNING with CTE) * test_exceptions.py: test improvement, to permit using possible different connectors and MySQL and MariaDB error message/parameter differences It would make sense to add this commit whatever the goal to have mariadb in breeze testing. the second commit [[d45c8ea](https://github.com/apache/airflow/pull/60133/commits/d45c8ea135eb3f1ed09b07effecaad2ec7f083bb)](https://github.com/apache/airflow/pull/60133/commits/b47cea389a9ed4f97a02820c992f505da82a4e4c) is to add mariadb to test suite Must i create a separate PR with only the first commit ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
