eladkal commented on code in PR #64661:
URL: https://github.com/apache/airflow/pull/64661#discussion_r3031902328
##########
providers/amazon/src/airflow/providers/amazon/aws/hooks/ec2.py:
##########
@@ -104,7 +105,9 @@ def stop_instances(self, instance_ids: list) -> dict:
"""
self.log.info("Stopping instances: %s", instance_ids)
- return self.conn.stop_instances(InstanceIds=instance_ids)
+ result = self.conn.stop_instances(InstanceIds=instance_ids)
+ self.log.debug("stop_instances response: %s",
result.get("StoppingInstances"))
Review Comment:
To be honest I think adding log.debug everywhere has very little value if
any.
To leverage this users must change the logging configuration in the Airflow
cluster. I don't know if anyone is actually doing it in production. It cary
risks and interruption for other jobs, also logs becomes so spammy that it's
very hard to figure out what you actually need.
I think that the improve debuggability track should be about finding a way
to change a specific DAG logging level without affecting the whole cluster -
then, PRs like this one has real value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
