bugraoz93 commented on code in PR #64688:
URL: https://github.com/apache/airflow/pull/64688#discussion_r3034264992
##########
airflow-core/src/airflow/api_fastapi/gunicorn_app.py:
##########
@@ -73,12 +73,14 @@ class AirflowUvicornWorker(UvicornWorker):
which would override any structlog configuration applied before gunicorn
starts.
Setting ``log_config=None`` prevents that. ``access_log=False`` disables
uvicorn's
built-in access logger because ``HttpAccessLogMiddleware`` handles access
logging.
+ ``date_header=False`` prevents duplicate Date headers when Flask WSGI
middleware is used.
"""
CONFIG_KWARGS = {
**UvicornWorker.CONFIG_KWARGS,
"log_config": None,
"access_log": False,
+ "date_header": False,
Review Comment:
I assume this disables entirely while from description I see our aim is to
prevent duplicate for Flask. We should handle there then
##########
airflow-core/newsfragments/64678.bugfix.rst:
##########
@@ -0,0 +1 @@
+Fix duplicate Date headers in API responses by disabling uvicorn's date header
generation
Review Comment:
Newsfragments only needed for breaking changes not for fixes. Those are
populated separately
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
