shivaam commented on PR #64726: URL: https://github.com/apache/airflow/pull/64726#issuecomment-4188150531
Hi, thanks for the fix! Two questions: 1. The hook removes all Date headers, not just the duplicate one. Did you consider that the Flask app is also used in tests via flask_app.test_client() (no Uvicorn in front)? In that path, nothing re-adds a Date header, so responses will end up with zero. Is that a concern? 2. Did you consider handling this inside the Flask app itself using a custom Response class (e.g. overriding get_wsgi_headers)? That way Flask never emits Date in the first place and we don't need a per-request hook. Curious if you tried that approach and ruled it out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
