chrisqiqiu opened a new pull request, #64755:
URL: https://github.com/apache/airflow/pull/64755
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
Add optional `retain_until_time` and `retention_mode` parameters to
`GCSHook.rewrite()` and `GcsToGcsOperator`, allowing object-level
retention to be applied to destination objects immediately after
copy/move operations.
This eliminates the need for a two-step "copy → set retention" workflow,
which is error-prone in compliance-driven pipelines where partial-success
can leave objects unprotected.
closes: #60853
**Changes:**
- `GCSHook.rewrite()` — accepts `retain_until_time` and `retention_mode`,
applies retention via `blob.patch()` after the rewrite completes
- `GCSToGCSOperator` — accepts the same parameters, passes them through
`_copy_single_object()` to the hook. Retention kwargs are only passed
when `retain_until_time` is set (fully backward compatible)
- Unit tests for both hook and operator covering retention, default mode,
and no-retention cases
**Testing:**
- All existing tests passed for
providers/google/tests/unit/google/cloud/hooks/test_gcs.py and
providers/google/tests/unit/google/cloud/transfers/test_gcs_to_gcs.py
<img width="786" height="656" alt="image"
src="https://github.com/user-attachments/assets/03c3e688-bdec-45e3-85df-c4860d7a7ba0";
/>
- Validated against real GCS with a retention-enabled bucket — retention
mode and retain_until_time correctly applied and verified
<img width="786" height="515" alt="image"
src="https://github.com/user-attachments/assets/20d76380-fe90-4794-8f04-c4b765b318a5";
/>
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
