ahilashsasidharan commented on code in PR #63994:
URL: https://github.com/apache/airflow/pull/63994#discussion_r3040584541
##########
airflow-core/src/airflow/ui/src/queries/useEditVariable.ts:
##########
@@ -78,12 +78,13 @@ export const useEditVariable = (
const parsedDescription =
editVariableRequestBody.description === "" ? undefined :
editVariableRequestBody.description;
+ const teamName = editVariableRequestBody.team_name === "" ? undefined :
editVariableRequestBody.team_name;
Review Comment:
Ignoring this. This behaviour is not observed on the UI. You utilize the
cross to clear the field and null is sent explicity in the request.
<img width="1154" height="1204" alt="Image"
src="https://github.com/user-attachments/assets/2e4da681-362c-4544-b6e8-ad844a718013";
/>
<img width="903" height="434" alt="Image"
src="https://github.com/user-attachments/assets/83a27d8a-2a23-4101-84c5-0e025b04e57a";
/>
<img width="1139" height="1206" alt="Image"
src="https://github.com/user-attachments/assets/81518d4f-6606-430f-aa23-4dd5b834109e";
/>
##########
airflow-core/src/airflow/ui/src/queries/useEditConnection.tsx:
##########
@@ -89,6 +89,11 @@ export const useEditConnection = (
if (requestBody.schema !== initialConnection.schema) {
updateMask.push("schema");
}
+ if (requestBody.team_name !== initialConnection.team_name) {
+ updateMask.push("team_name");
+ }
+
+ const teamName = requestBody.team_name === "" ? undefined :
requestBody.team_name;
Review Comment:
Ignoring this comment and following what is already in the codebase in the
"airflow-core/src/airflow/ui/src/queries/useEditPool.ts" as this does not seem
to cause issues from my UI testing. Refer to other comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
