potiuk opened a new pull request, #64831: URL: https://github.com/apache/airflow/pull/64831
Extract the monolithic pr_commands.py (12,400 lines) into 7 focused modules with clean separation of concerns: - pr_github.py: GitHub API layer (GraphQL/REST, auth, labels, mutations) - pr_actions.py: Action recommendation and execution with named thresholds - pr_checks.py: CI check analysis, log parsing, failure detection - pr_workflows.py: Workflow run management (approve, cancel, rerun) - pr_authors.py: Author profiling and filtering (AuthorFilter enum) - pr_fetching.py: GraphQL PR data fetching and assembly - pr_enrichment.py: PR enrichment, filtering, and categorization pipeline The most important module is pr_actions.py which encapsulates all decision logic with named constants (AUTHOR_FLAGGED_CLOSE_THRESHOLD, MAX_CI_FAILURES_FOR_RERUN, MAX_COMMITS_BEHIND_FOR_RERUN) replacing magic numbers. pr_commands.py uses backward-compatible import aliases so all existing code continues to work without modification. 80 new tests added across 5 test files (174 total tests passing). https://claude.ai/code/session_01JaPYna6Pnw4HMr4t5aCMiL <!-- SPDX-License-Identifier: Apache-2.0 https://www.apache.org/licenses/LICENSE-2.0 --> <!-- Thank you for contributing! Please provide above a brief description of the changes made in this pull request. Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/ Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping (in general) for the review if you do not see reaction for a few days (72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications. In case of an existing issue, reference it using one of the following: * closes: #ISSUE * related: #ISSUE --> --- ##### Was generative AI tooling used to co-author this PR? <!-- If generative AI tooling has been used in the process of authoring this PR, please change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by". --> - [ ] Yes (please specify the tool below) <!-- Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions) --> --- * Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged. * For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. * When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). * For significant user-facing changes create newsfragment: `{pr_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments). You can add this file in a follow-up commit after the PR is created so you know the PR number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
