github-actions[bot] opened a new pull request, #64853:
URL: https://github.com/apache/airflow/pull/64853
* Fix Gantt view "Error invalid date" on running DagRun (#64599)
The Gantt chart scale calculation used new Date() to parse date strings,
which fails for non-UTC timezone abbreviations, returning NaN and
crashing Chart.js's time scale.
Changes:
- Replace new Date().getTime() with dayjs().valueOf() for reliable date
parsing in the x-axis scale min/max calculations.
- Add unit tests for Gantt chart scale calculations and data
transformation covering completed tasks, running tasks with null end
dates, groups with null dates, and ISO date string validity.
* Address review feedback: fix static checks and consistency
- Fix object property ordering in test data (alphabetical)
- Import vi as type-only from vitest
- Fix duration field position in selectedRun objects
- Make dayjs null handling consistent between max and min scale
calculations (remove unnecessary ?? undefined)
* Fix ESLint no-empty-function error in Gantt utils test
* Fix TypeScript type errors in Gantt utils tests
Update test fixtures to match current generated types:
- Add has_missed_deadline to GridRunsResponse objects
- Remove dag_id and map_index from GanttTaskInstance objects
- Add depth to GridTask objects
- Add task_display_name to LightGridTaskInstanceSummary objects
* Fix translate type to use TFunction in Gantt utils tests
(cherry picked from commit 0b2efb99e6ff4857adcdb0acd3519451c57ad61e)
Co-authored-by: Ashir Alam <[email protected]>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
