potiuk commented on PR #64810: URL: https://github.com/apache/airflow/pull/64810#issuecomment-4205945024
> Couple of questions: > Runtime-wise, what is the impact on local hook duration? Definitely the image build time - or even checking if it needs rebuild - many times people do not have latest image and that requires waiting for the build. The mypy itself depends on docker runtime - on the default Docker Desktop - there are few seconds overhead. > Coverage-wise, how does the folder-level strategy compare to the file-level one? Stability is much higher. When you run mypy on individual files you might get different results. @jscheffl > @potiuk At least on another PR without changes in Python mypy is now complianing: > https://github.com/apache/airflow/actions/runs/24052602891/job/70154231167?pr=64811 - did this backport broke the v3-2-test branch? Or was it broken before? I don't think it's related, it has been running old approach. I did not see similar issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
