Dev-iL opened a new pull request, #64972:
URL: https://github.com/apache/airflow/pull/64972
## Summary
- Add AST-based static analysis tests that detect 3 migration anti-patterns
(MIG001/MIG002/MIG003) across all migration files
- Add unit tests for `disable_sqlite_fkeys`,
`mysql_drop_foreignkey_if_exists`, and `ignore_sqlite_value_error` with real
database backends
- Fix confirmed SQLite PRAGMA bugs in migrations 0100 and 0106
- Add `# noqa: MIG0XX` suppression comments to 20 old migrations with
acknowledged violations
related: #64876
## Motivation
PR #64876 fixed a bug in migration 0097 where `UPDATE` statements before the
`disable_sqlite_fkeys` context manager triggered SQLAlchemy autobegin, making
`PRAGMA foreign_keys=off` a no-op on SQLite. The same pattern existed in
migrations 0100 and 0106 but had no automated detection.
This PR adds two layers of protection:
1. **Static analysis tests** (`test_migration_patterns.py`) — AST-based
parametrized tests that scan every migration file for known anti-patterns:
- **MIG001**: DML (`UPDATE`/`INSERT`/`DELETE`) via `op.execute()` before
`disable_sqlite_fkeys` — triggers autobegin, making PRAGMA a no-op
- **MIG002**: DDL (`op.add_column`, `op.batch_alter_table`, etc.) before
`disable_sqlite_fkeys` — same autobegin issue
- **MIG003**: DML via `op.execute()` without `context.is_offline_mode()`
guard — produces data-dependent SQL in offline mode
2. **Utils unit tests** (`test_migration_utils.py`) — tests for the 3
most-used migration utility functions using real database connections via
`pytest.mark.db_test`.
## Changes
### New files
- `airflow-core/tests/unit/migrations/test_migration_patterns.py` — 336
parametrized tests (3 rules x 112 migration files), with `# noqa: MIG0XX`
suppression support and ruff-style rule documentation in the module docstring
- `airflow-core/tests/unit/migrations/test_migration_utils.py` — 8 tests for
`disable_sqlite_fkeys` (PRAGMA on/off on SQLite, no-op on others),
`mysql_drop_foreignkey_if_exists` (MySQL-only, skipped elsewhere), and
`ignore_sqlite_value_error` (ValueError suppression on SQLite)
### Bug fixes
- **Migration 0100** (`add_timetable_type`): moved `batch_alter_table`
(add_column) and `op.execute(UPDATE)` inside the `disable_sqlite_fkeys` block —
same pattern as the fix in #64876
- **Migration 0106** (`add_partition_key`): moved `op.add_column("dag_run",
...)` inside the `disable_sqlite_fkeys` block
### Suppressions
- Added `# noqa: MIG003 -- <reason>` to 62 DML lines across 22 migration
files where the DML is intentional and the migration is designed to run online
only
- Added `external = ["MIG"]` to `[tool.ruff.lint]` in `pyproject.toml` to
prevent `RUF100` from stripping the custom noqa comments
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [x] Yes (please specify the tool below)
Generated-by: Claude Opus 4.6 following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
