Vamsi-klu commented on PR #64982: URL: https://github.com/apache/airflow/pull/64982#issuecomment-4219402037
The change itself looks fine to me. One thing I think is still missing is a test around the deprecation warning in `NOTES.txt`. The chart tests cover the rendered annotation behavior, but this warning is part of the upgrade path too. It would be good to have one Helm test that checks the warning appears when `workers.annotations` is set, so that message does not quietly disappear later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
