Copilot commented on code in PR #64888: URL: https://github.com/apache/airflow/pull/64888#discussion_r3062518512
########## airflow-core/src/airflow/settings.py: ########## @@ -30,7 +30,7 @@ import pluggy from packaging.version import Version -from sqlalchemy import create_engine +from sqlalchemy import create_engine, make_url Review Comment: `make_url` is imported from `sqlalchemy` top-level here. In this repo, other call sites import it from `sqlalchemy.engine`/`sqlalchemy.engine.url`, and SQLAlchemy’s public API typically exposes `make_url` via `sqlalchemy.engine` rather than `sqlalchemy` root. Importing it from the root module risks an `ImportError` at runtime when `airflow.settings` is imported. Please switch to `from sqlalchemy.engine import make_url` (or `from sqlalchemy.engine.url import make_url`) to match the established usage and avoid compatibility issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
