Copilot commented on code in PR #62965:
URL: https://github.com/apache/airflow/pull/62965#discussion_r3066484421
##########
airflow-core/src/airflow/ui/public/i18n/locales/pt-BR/hitl.json:
##########
@@ -0,0 +1,40 @@
+{
+ "filters": {
+ "body": "Corpo",
+ "createdAt": "Criado em",
+ "createdAtFrom": "Criado De",
+ "createdAtTo": "Criado Até",
Review Comment:
`createdAtFrom`/`createdAtTo` are present here but don’t exist in the source
`en/hitl.json` and aren’t referenced in the UI code (no `createdAtFrom` usage).
This makes the locale file diverge from the canonical key set and can lead to
unused/never-loaded translations; consider removing these keys (or adding them
to `en` + wiring them in the UI if they’re intended).
```suggestion
```
##########
airflow-core/src/airflow/ui/public/i18n/locales/pt-BR/assets.json:
##########
@@ -0,0 +1,37 @@
+{
+ "additional_data": "Dados adicionais",
+ "asset_many": "Asset",
Review Comment:
`asset_many` is used as the plural label (English source value is "Assets"),
but this translation is singular ("Asset"). This will display incorrect wording
when the UI expects a plural form; update `asset_many` to a plural form
appropriate for pt-BR.
```suggestion
"asset_many": "Assets",
```
##########
go-sdk/pkg/worker/runner_test.go:
##########
@@ -189,9 +188,8 @@ func (s *WorkerSuite)
TestTaskReturnErrorReportsFailedState() {
}
func (s *WorkerSuite) TestTaskHeartbeatsWhileRunning() {
- s.T().Parallel()
id := uuid.New().String()
- callCount := 0
+ var callCount atomic.Int32
testWorkload := newTestWorkLoad(id, id[:8])
Review Comment:
This PR is described as adding a new UI locale + CODEOWNERS entry, but it
also changes Go SDK worker tests (removing Parallel calls and switching to
atomic.Int32). Consider splitting the Go test changes into a separate PR (or
updating the PR description) so the translation/CODEOWNERS review and approval
can be handled independently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
