Copilot commented on code in PR #64823:
URL: https://github.com/apache/airflow/pull/64823#discussion_r3066486138
##########
airflow-core/tests/unit/serialization/test_encoders.py:
##########
@@ -35,23 +57,7 @@
FileDeleteTrigger(filepath="/tmp/test.txt", poke_interval=5.0),
id="primitive_kwargs_only",
),
- pytest.param(AwaitMessageTrigger(topics=()), id="empty_tuple"),
- pytest.param(
- AwaitMessageTrigger(topics=("fizz_buzz",), poll_timeout=1.0,
commit_offset=True),
- id="single_topic_tuple",
- ),
- pytest.param(
- AwaitMessageTrigger(
- topics=["t1", "t2"],
- apply_function="my.module.func",
- apply_function_args=["a", "b"],
- apply_function_kwargs={"key": "value"},
- kafka_config_id="my_kafka",
- poll_interval=2,
- poll_timeout=3,
- ),
- id="all_non_primitive_kwargs",
- ),
+ *_kafka_params,
]
Review Comment:
When the Kafka provider isn't installed, `_kafka_params` becomes empty, so
all tests still run but they only exercise the primitive-only
`FileDeleteTrigger` path. That means the non-primitive (e.g. tuple)
wrapping/unwrapping behavior that motivated this suite isn't validated in the
default/core-only test environment. Consider adding at least one
always-available trigger (e.g. a `providers.standard` trigger instantiated with
a tuple kwarg, or a small test-only trigger stub) to `_TRIGGER_PARAMS` so the
non-primitive serialization/idempotency logic is covered even without the Kafka
provider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
