Copilot commented on code in PR #64965:
URL: https://github.com/apache/airflow/pull/64965#discussion_r3066487630
##########
.pre-commit-config.yaml:
##########
@@ -18,7 +18,7 @@
default_stages: [pre-commit, pre-push]
minimum_prek_version: '0.3.4'
default_language_version:
- python: python3
+ python: python310
Review Comment:
`default_language_version.python` is set to `python310`, which is not a
standard interpreter executable name on many systems (pre-commit will try to
run `python310`). Elsewhere in this repo the convention is `python3` (e.g.
`airflow-core/.pre-commit-config.yaml:21` and even this file sets
`language_version: python3` for the `bandit` hook). Consider reverting to
`python3` (or, if pinning is required, use an executable name that actually
exists across platforms, and align all pre-commit configs consistently).
```suggestion
python: python3
```
##########
.pre-commit-config.yaml:
##########
@@ -18,7 +18,7 @@
default_stages: [pre-commit, pre-push]
minimum_prek_version: '0.3.4'
default_language_version:
- python: python3
+ python: python310
node: 22.19.0
Review Comment:
The PR is titled/described as a documentation typo fix, but this hunk
changes the repository’s pre-commit Python interpreter selection. If this is
intentional, the PR title/description should reflect a tooling change;
otherwise this looks like an accidental edit and should be reverted to keep the
PR scoped to docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
