Copilot commented on code in PR #62739:
URL: https://github.com/apache/airflow/pull/62739#discussion_r3066485022


##########
providers/google/src/airflow/providers/google/cloud/hooks/vertex_ai/pipeline_job.py:
##########
@@ -223,6 +224,8 @@ def run_pipeline_job(
             Private services access must already be configured for the 
network. If left unspecified, the
             network set in aiplatform.init will be used. Otherwise, the job is 
not peered with any network.
         :param create_request_timeout: Optional. The timeout for the create 
request in seconds.
+        :param reserved_ip_ranges: Optional. A list of names for the reserved 
IP ranges under the VPC network 

Review Comment:
   The added `:param reserved_ip_ranges:` docstring line contains trailing 
whitespace at the end of the line. Please remove it to avoid formatting/lint 
issues.
   ```suggestion
           :param reserved_ip_ranges: Optional. A list of names for the 
reserved IP ranges under the VPC network
   ```



##########
providers/google/src/airflow/providers/google/cloud/hooks/vertex_ai/pipeline_job.py:
##########
@@ -320,6 +325,8 @@ def submit_pipeline_job(
             Private services access must already be configured for the 
network. If left unspecified, the
             network set in aiplatform.init will be used. Otherwise, the job is 
not peered with any network.
         :param create_request_timeout: Optional. The timeout for the create 
request in seconds.
+        :param reserved_ip_ranges: Optional. A list of names for the reserved 
IP ranges under the VPC network 

Review Comment:
   The added `:param reserved_ip_ranges:` docstring line contains trailing 
whitespace at the end of the line. Please remove it to avoid formatting/lint 
issues.
   ```suggestion
           :param reserved_ip_ranges: Optional. A list of names for the 
reserved IP ranges under the VPC network
   ```



##########
providers/google/src/airflow/providers/google/cloud/operators/vertex_ai/pipeline_job.py:
##########
@@ -88,6 +88,8 @@ class RunPipelineJobOperator(GoogleCloudBaseOperator):
         Private services access must already be configured for the network. If 
left unspecified, the
         network set in aiplatform.init will be used. Otherwise, the job is not 
peered with any network.
     :param create_request_timeout: Optional. The timeout for the create 
request in seconds.
+    :param reserved_ip_ranges: Optional. A list of names for the reserved IP 
ranges under the VPC network 

Review Comment:
   There is trailing whitespace at the end of the new `:param 
reserved_ip_ranges:` docstring line(s). This can cause pre-commit/lint 
failures; please remove the trailing spaces to match existing docstring 
formatting (e.g., in `vertex_ai/ray.py`).
   ```suggestion
       :param reserved_ip_ranges: Optional. A list of names for the reserved IP 
ranges under the VPC network
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to