Copilot commented on code in PR #64906:
URL: https://github.com/apache/airflow/pull/64906#discussion_r3066496961
##########
chart/values.schema.json:
##########
@@ -5242,6 +5242,10 @@
"null"
]
}
+ },
+ "team_name": {
+ "description": "Team name for the dag bundle.",
Review Comment:
Airflow terminology typically capitalizes “DAG”. Consider updating the
description to “Team name for the DAG bundle.” for consistency and clarity in
generated schema docs.
```suggestion
"description": "Team name for the DAG
bundle.",
```
##########
chart/values.schema.json:
##########
@@ -5242,6 +5242,10 @@
"null"
]
}
+ },
+ "team_name": {
+ "description": "Team name for the dag bundle.",
+ "type": "string"
Review Comment:
`team_name` is added as `"type": "string"` while the immediately preceding
property in this object appears to allow `null` (the context right above shows
`"null"` included in a type list). If `team_name` is intended to be optional
and users might set it explicitly to `null` (a common Helm values pattern), the
schema should allow `["string", "null"]` for consistency and to avoid
unexpected validation failures.
```suggestion
"type": [
"string",
"null"
]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
