Miretpl commented on code in PR #64980:
URL: https://github.com/apache/airflow/pull/64980#discussion_r3066902979
##########
helm-tests/tests/helm_tests/airflow_core/test_worker.py:
##########
@@ -664,23 +664,67 @@ def test_tolerations(self):
{"key": "dynamic-pods", "operator": "Equal", "value": "true",
"effect": "NoSchedule"}
]
- def test_topology_spread_constraints(self):
- expected_topology_spread_constraints = [
+ @pytest.mark.parametrize(
+ "workers_values",
+ [
+ {
+ "topologySpreadConstraints": [
+ {
+ "maxSkew": 1,
+ "topologyKey": "foo",
+ "whenUnsatisfiable": "ScheduleAnyway",
+ "labelSelector": {"matchLabels": {"tier": "airflow"}},
+ }
+ ]
+ },
+ {
+ "celery": {
+ "topologySpreadConstraints": [
+ {
+ "maxSkew": 1,
+ "topologyKey": "foo",
+ "whenUnsatisfiable": "ScheduleAnyway",
+ "labelSelector": {"matchLabels": {"tier":
"airflow"}},
+ }
+ ]
+ }
+ },
Review Comment:
Not sure if it is worth it, as everything is done in this way and will be
removed with version 2.0 of the chart. I will think about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
