kosiew commented on code in PR #64960: URL: https://github.com/apache/airflow/pull/64960#discussion_r3067572009
########## providers/databricks/src/airflow/providers/databricks/utils/retry.py: ########## @@ -0,0 +1,35 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from typing import Any + +from airflow.sdk.serde import serialize as serde_serialize + + +def validate_deferrable_databricks_retry_args(retry_args: dict[Any, Any] | None, *, owner: str) -> None: + """Validate retry args that need to cross the trigger serialization boundary.""" + if retry_args is None: + return + + try: + serde_serialize(retry_args) + except (AttributeError, RecursionError, TypeError) as err: + raise ValueError( + f"{owner} does not support non-serializable databricks_retry_args when deferrable=True. " + "Use JSON-serializable values, remove callable retry strategies, or disable deferrable mode." + ) from err Review Comment: Agreed. The same validation helper is used from both the operator-facing databricks_retry_args path and the trigger-facing retry_args path, so the message should name both to avoid confusion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
