shivaam commented on PR #64942: URL: https://github.com/apache/airflow/pull/64942#issuecomment-4229487255
Thanks for the reviews @nailo2c @Vamsi-klu! Addressed feedback in 7e6ede34cd: - **Log message** (@Vamsi-klu): Error log now shows `"version latest"` instead of `"version None"` when `bundle_version` is None. - **Test assertion** (@Copilot): Test now starts with `bundle.path = None`, uses an `initialize()` side effect to materialize it, and asserts on the queued `DagFileInfo.bundle_path` — validates user-visible behavior instead of just the internal call. - **`is_initialized` guard** (@Copilot): Skipped. `DagBundlesManager().get_bundle()` returns a fresh instance every call, so `is_initialized` is always False and the guard would be a no-op. It would also require modifying the two existing callback tests, which our review guidelines flag as a risk signal. **Local verification** (@nailo2c): Tested end-to-end in Breeze with a local bare Git repo + `GitDagBundle` + a DAG with `disable_bundle_versioning=True` and `on_success_callback`. After triggering, the `on_success_callback` fires and its log message appears in the dag-processor logs. Without the fix, the callback is silently dropped. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
