This is an automated email from the ASF dual-hosted git repository.
choo121600 pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/airflow.git
The following commit(s) were added to refs/heads/main by this push:
new 919d4e7aced Replace file-level eslint-disable with per-line
annotations (#64654)
919d4e7aced is described below
commit 919d4e7aced833d69971b2b72de329a2380fa131
Author: Yeonguk Choo <[email protected]>
AuthorDate: Tue Apr 14 18:03:14 2026 +0900
Replace file-level eslint-disable with per-line annotations (#64654)
---
airflow-core/src/airflow/ui/tests/e2e/fixtures/asset-data.ts | 5 ++---
airflow-core/src/airflow/ui/tests/e2e/fixtures/audit-log-data.ts | 5 ++---
airflow-core/src/airflow/ui/tests/e2e/fixtures/dag-runs-data.ts | 5 ++---
.../src/airflow/ui/tests/e2e/fixtures/task-instances-data.ts | 3 +--
airflow-core/src/airflow/ui/tests/e2e/fixtures/xcom-data.ts | 3 +--
5 files changed, 8 insertions(+), 13 deletions(-)
diff --git a/airflow-core/src/airflow/ui/tests/e2e/fixtures/asset-data.ts
b/airflow-core/src/airflow/ui/tests/e2e/fixtures/asset-data.ts
index 79b4e993c67..bca673fab10 100644
--- a/airflow-core/src/airflow/ui/tests/e2e/fixtures/asset-data.ts
+++ b/airflow-core/src/airflow/ui/tests/e2e/fixtures/asset-data.ts
@@ -20,12 +20,10 @@
/**
* Asset data fixture — triggers asset_produces_1 DAG and waits for success.
*/
-
-/* eslint-disable react-hooks/rules-of-hooks -- Playwright's `use` is not a
React Hook. */
import { test as base } from "tests/e2e/fixtures";
import {
- safeCleanupDagRun,
apiTriggerDagRun,
+ safeCleanupDagRun,
waitForDagReady,
waitForDagRunStatus,
} from "tests/e2e/utils/test-helpers";
@@ -54,6 +52,7 @@ export const test = base.extend<Record<never, never>, {
assetData: AssetData }>(
timeout: 120_000,
});
+ // eslint-disable-next-line react-hooks/rules-of-hooks
await use({ dagId });
} finally {
if (createdRunId !== undefined) {
diff --git a/airflow-core/src/airflow/ui/tests/e2e/fixtures/audit-log-data.ts
b/airflow-core/src/airflow/ui/tests/e2e/fixtures/audit-log-data.ts
index c160958aec1..99f6e08f78d 100644
--- a/airflow-core/src/airflow/ui/tests/e2e/fixtures/audit-log-data.ts
+++ b/airflow-core/src/airflow/ui/tests/e2e/fixtures/audit-log-data.ts
@@ -20,13 +20,11 @@
/**
* Audit log data fixture — triggers DAG runs to generate audit log entries.
*/
-
-/* eslint-disable react-hooks/rules-of-hooks -- Playwright's `use` is not a
React Hook. */
import { testConfig } from "playwright.config";
import { test as base } from "tests/e2e/fixtures";
import {
- safeCleanupDagRun,
apiTriggerDagRun,
+ safeCleanupDagRun,
waitForDagReady,
waitForDagRunStatus,
} from "tests/e2e/utils/test-helpers";
@@ -57,6 +55,7 @@ export const test = base.extend<Record<never, never>, {
auditLogData: AuditLogDa
});
}
+ // eslint-disable-next-line react-hooks/rules-of-hooks
await use({ dagId });
} finally {
for (const runId of createdRunIds) {
diff --git a/airflow-core/src/airflow/ui/tests/e2e/fixtures/dag-runs-data.ts
b/airflow-core/src/airflow/ui/tests/e2e/fixtures/dag-runs-data.ts
index 3c07bbefd4d..f093808fafd 100644
--- a/airflow-core/src/airflow/ui/tests/e2e/fixtures/dag-runs-data.ts
+++ b/airflow-core/src/airflow/ui/tests/e2e/fixtures/dag-runs-data.ts
@@ -20,14 +20,12 @@
/**
* DAG Runs page data fixture — creates runs across two DAGs for filtering
tests.
*/
-
-/* eslint-disable react-hooks/rules-of-hooks -- Playwright's `use` is not a
React Hook. */
import { testConfig } from "playwright.config";
import { test as base } from "tests/e2e/fixtures";
import {
apiCreateDagRun,
- safeCleanupDagRun,
apiSetDagRunState,
+ safeCleanupDagRun,
uniqueRunId,
waitForDagReady,
} from "tests/e2e/utils/test-helpers";
@@ -79,6 +77,7 @@ export const test = base.extend<Record<never, never>, {
dagRunsPageData: DagRuns
});
createdRuns.push({ dagId: dag2Id, runId: runId3 });
+ // eslint-disable-next-line react-hooks/rules-of-hooks
await use({ dag1Id, dag2Id });
} finally {
for (const { dagId, runId } of createdRuns) {
diff --git
a/airflow-core/src/airflow/ui/tests/e2e/fixtures/task-instances-data.ts
b/airflow-core/src/airflow/ui/tests/e2e/fixtures/task-instances-data.ts
index cde2f4e6aa2..b212b2c8884 100644
--- a/airflow-core/src/airflow/ui/tests/e2e/fixtures/task-instances-data.ts
+++ b/airflow-core/src/airflow/ui/tests/e2e/fixtures/task-instances-data.ts
@@ -20,8 +20,6 @@
/**
* Task instances data fixture — creates runs with success/failed task
instances.
*/
-
-/* eslint-disable react-hooks/rules-of-hooks -- Playwright's `use` is not a
React Hook. */
import { expect, type APIRequestContext } from "@playwright/test";
import { testConfig } from "playwright.config";
import { test as base } from "tests/e2e/fixtures";
@@ -100,6 +98,7 @@ export const test = base.extend<Record<never, never>, {
taskInstancesData: TaskI
createdRunIds.push(runId2);
await setAllTaskInstanceStates(authenticatedRequest, { dagId, runId:
runId2, state: "failed" });
+ // eslint-disable-next-line react-hooks/rules-of-hooks
await use({ dagId });
} finally {
for (const runId of createdRunIds) {
diff --git a/airflow-core/src/airflow/ui/tests/e2e/fixtures/xcom-data.ts
b/airflow-core/src/airflow/ui/tests/e2e/fixtures/xcom-data.ts
index 81dab06f8d0..5942d2aaec1 100644
--- a/airflow-core/src/airflow/ui/tests/e2e/fixtures/xcom-data.ts
+++ b/airflow-core/src/airflow/ui/tests/e2e/fixtures/xcom-data.ts
@@ -20,8 +20,6 @@
/**
* XCom data fixture — triggers example_xcom DAG runs to generate XCom entries.
*/
-
-/* eslint-disable react-hooks/rules-of-hooks -- Playwright's `use` is not a
React Hook. */
import { testConfig } from "playwright.config";
import { test as base } from "tests/e2e/fixtures";
import {
@@ -67,6 +65,7 @@ export const test = base.extend<Record<never, never>, {
xcomRunsData: XcomRunsDa
});
}
+ // eslint-disable-next-line react-hooks/rules-of-hooks
await use({ dagId, xcomKey: "return_value" });
} finally {
for (const runId of createdRunIds) {
