Copilot commented on code in PR #65196:
URL: https://github.com/apache/airflow/pull/65196#discussion_r3079288091
##########
airflow-core/src/airflow/dag_processing/manager.py:
##########
@@ -1221,7 +1221,10 @@ def prepare_file_queue(self, known_files: dict[str,
set[DagFileInfo]]):
if self.log.isEnabledFor(logging.DEBUG):
for path, processor in self._processors.items():
self.log.debug(
- "File path %s is still being processed (started: %s)",
path, processor.start_time
+ "File path %s is still being processed (started at: %.2f,
duration: %.2fs)",
+ path,
+ processor.start_time,
+ time.monotonic() - processor.start_time,
Review Comment:
`processor.start_time` is a `time.monotonic()` value (not wall-clock). The
new label `started at` reads like a real timestamp and can still mislead;
consider wording that explicitly indicates monotonic (e.g. `monotonic start:`)
while keeping the value. Also, to keep durations consistent (and avoid repeated
syscalls), capture `now = time.monotonic()` once before iterating and use `now
- processor.start_time`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
