bbovenzi commented on code in PR #64666:
URL: https://github.com/apache/airflow/pull/64666#discussion_r3081293935
##########
airflow-core/src/airflow/ui/tests/e2e/pages/AssetListPage.ts:
##########
@@ -43,7 +43,10 @@ export class AssetListPage extends BasePage {
}
public async navigate(): Promise<void> {
- await this.navigateTo("/assets");
+ await expect(async () => {
+ await this.navigateTo("/assets");
+ await this.page.waitForURL(/.*assets/, { timeout: 10_000 });
+ }).toPass({ intervals: [2000], timeout: 60_000 });
Review Comment:
Do we really need a fully minute?
##########
airflow-core/src/airflow/ui/tests/e2e/pages/BasePage.ts:
##########
@@ -18,7 +18,6 @@
*/
import { expect } from "@playwright/test";
import type { Page, Locator } from "@playwright/test";
-import { waitForServerReady } from "tests/e2e/utils/health";
Review Comment:
So we don't need this anymore cause we instead `waitUntil:
"domcontentloaded"`. Is that right?
If so, can we just delete `waitForServerReady` entirely since we're no
longer calling it anywhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
