[ 
https://issues.apache.org/jira/browse/AIRFLOW-6324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17001886#comment-17001886
 ] 

ASF GitHub Bot commented on AIRFLOW-6324:
-----------------------------------------

mik-laj commented on pull request #6877: [AIRFLOW-6324] Hide celery commands 
when executor is not CeleryExecutor
URL: https://github.com/apache/airflow/pull/6877
 
 
   
   If the Celery executor is not used, commands specific to it are still 
displayed. This is confusing to novice users because they try to run commands 
that do not work.
   
   In addition, the celery commands have been grouped into one subcommand.
   
   | Old command               | New command                        |
   |---------------------------|------------------------------------|
   | ``airflow worker``        | ``airflow celery worker``          |
   | ``airflow flower``        | ``airflow celery flower``          |
   
   ---
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow 
Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references 
them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-6324
     - In case you are fixing a typo in the documentation you can prepend your 
commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
     - In case you are proposing a fundamental code change, you need to create 
an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)).
     - In case you are adding a dependency, check if the license complies with 
the [ASF 3rd Party License 
Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI 
changes:
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes 
how to use it.
     - All the public functions and the classes in the PR contain docstrings 
that explain what it does
     - If you implement backwards incompatible changes, please leave a note in 
the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so 
we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Hide celery commands when executor is not CeleryExecutor
> --------------------------------------------------------
>
>                 Key: AIRFLOW-6324
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6324
>             Project: Apache Airflow
>          Issue Type: New Feature
>          Components: cli
>    Affects Versions: 1.10.6
>            Reporter: Kamil Bregula
>            Priority: Major
>
> If the Celery executor is not used, commands specific to it are still 
> displayed. This is confusing to novice users because they try to run commands 
> that do not work.
> In addition, the celery commands have been grouped into one subcommand.
> |*Old command*|*New command*|
> |``airflow worker``|``airflow celery worker``|
> |``airflow flower``|``airflow celery flower``|



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to