xBis7 commented on code in PR #63932:
URL: https://github.com/apache/airflow/pull/63932#discussion_r3092169249
##########
providers/edge3/src/airflow/providers/edge3/worker_api/routes/jobs.py:
##########
@@ -92,8 +88,8 @@ def fetch(
session.commit()
# Edge worker does not backport emitted Airflow metrics, so export some
metrics
tags = {"dag_id": job.dag_id, "task_id": job.task_id, "queue": job.queue}
- if DualStatsManager is not None:
- DualStatsManager.incr("edge_worker.ti.start", tags=tags)
+ if AIRFLOW_V_3_2_PLUS:
Review Comment:
This creates another issue. Let's assume that this PR gets merged with
checks such as
```
if AIRFLOW_V_3_3_PLUS:
```
and then we cut a new minor release that includes the changes. The target
version in the minor release will be changed from `3.3.0` to `3.2.1`. In that
case, the providers will break because they will always execute the `else`
block but `airflow-core` will need the code from the 1st block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
