alamashir commented on code in PR #65499:
URL: https://github.com/apache/airflow/pull/65499#discussion_r3114553290


##########
providers/google/provider.yaml:
##########
@@ -146,6 +146,7 @@ integrations:
   - integration-name: Google BigQuery
     how-to-guide:
       - /docs/apache-airflow-providers-google/operators/cloud/bigquery.rst
+      - 
/docs/apache-airflow-providers-google/operators/cloud/bigquery_routines.rst

Review Comment:
   Thanks for the review! I believe this is already covered — `provider.yaml`'s 
`integrations.*.python-modules` list registers Python **modules**, not 
individual classes:
   
   - `provider.yaml:487` registers 
`airflow.providers.google.cloud.operators.bigquery` — covers all 5 new routine 
operators (`BigQueryCreateRoutineOperator`, `BigQueryUpdateRoutineOperator`, 
`BigQueryDeleteRoutineOperator`, `BigQueryGetRoutineOperator`, 
`BigQueryListRoutinesOperator`)
   - `provider.yaml:646` registers 
`airflow.providers.google.cloud.sensors.bigquery` — covers 
`BigQueryRoutineExistenceSensor`
   
   This is the same pattern used for every existing BigQuery operator 
(`BigQueryInsertJobOperator`, `BigQueryCheckOperator`, etc.) — none of them are 
enumerated individually. A grep for class names like 
`BigQueryCreate`/`BigQueryUpdate`/etc. in `provider.yaml` returns zero matches, 
confirming no per-class entries exist.
   
   CI's `update-providers-build-files` hook regenerates `get_provider_info.py` 
from `provider.yaml` and is green after the latest push, which further confirms 
registration is complete.
   
   Happy to add something else if I've missed the intent — let me know!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to