zhongjiajie commented on a change in pull request #6850: [AIRFLOW-6296] add
mssql odbc hook
URL: https://github.com/apache/airflow/pull/6850#discussion_r361366897
##########
File path: setup.py
##########
@@ -275,6 +275,7 @@ def write_version(filename: str =
os.path.join(*["airflow", "git_version"])):
]
mssql = [
'pymssql~=2.1.1',
+ 'pyodbc',
Review comment:
As I comment as Slack, I think we should **REPLACE** the old mssql hook
instead of and a new one. It will confuse user and we don't know which to use
if want to add a new transfer between mssql and other one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services