internetcoffeephone commented on code in PR #66198: URL: https://github.com/apache/airflow/pull/66198#discussion_r3190087480
########## airflow-core/src/airflow/ui/src/components/MarkAs/Run/MarkRunAsButton.test.tsx: ########## Review Comment: @bbovenzi thanks for your review. Re: tests, I’d say so as well, were it not that this is a fix for a regression. The first time in 2.x it was a well-intended change, then the same choice was made in the 3.x overhaul. I’m not sure how to better encode that this button behavior is an explicit choice other than a unit test - maybe a comment? Otherwise I predict someone will change it back again in 2 years or so :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
