potiuk commented on PR #65513: URL: https://github.com/apache/airflow/pull/65513#issuecomment-4381471136
> Is there an actual problem with the versions released on pypi? Do they not work, or issue deprecation warnings in code? Is someone threatening to remove them from PyPI? > > Until one of these comes to pass, Code that Works and is Released should continue to be used, there is no harm in using 11 year old code if it works. It doesn't matter if it is unmaintained if it doesn't need changes. > > (Non blocking, but very strongly held) -1 we do not need to do this. `lockfile` works, just use it. > > If we really want to not have these two as deps (again, I don't see the problem as they have been working for years, and aren't broken right now) then I think we should _vendor them as is, not reimplement it. It makes it clearer that "we are carrying this code" vs "we have written this code ourselves". And the less code we can write the better. I think we have to definitely have a discussion about it in devlist. This is a good call to be clear about some criteria that we apply and I will definitely lead a discussion about this very soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
