paultmathew opened a new pull request, #66433:
URL: https://github.com/apache/airflow/pull/66433
Fixes #66428.
## Why
`/required_actions` and the per-DAG / per-Run / per-Task Required Actions
tabs all silently dropped HITL rows for mapped task instances because the
listing component hard-coded `mapIndex: parseInt(searchParams.get(MAP_INDEX)
?? "-1", 10)`,
which always sent `map_index=-1` and filtered to non-mapped TIs only.
Issue #66428 has the full repro and access-log evidence.
## What
* Pass `mapIndex` to the listing call only when the user has explicitly
set the `map_index` URL search param. Default behaviour is now
"all map indexes" (no filter) instead of "non-mapped only", and
`map_index=-1` continues to work as an opt-in filter for non-mapped
task instances.
* Fix the auto-refresh predicate that compared
`responded_at === undefined` instead of `=== null`. The API serializes
`responded_at` as JSON `null`, never an omitted field, so the predicate
never matched and the page never polled for new pending actions while
open. The issue's "Anything else" section flagged this; the OP offered
to roll it into the same PR and there has been no maintainer pushback,
so it is included here.
## Tests
* Added `HITLTaskInstances.test.tsx` covering the three URL-param
branches (`map_index` absent / set to `2` / set to `-1`) and the
refetch predicate for both `responded_at: null` and a populated value.
* Locally verified with `pnpm exec vitest run
src/pages/HITLTaskInstances/HITLTaskInstances.test.tsx`
(5/5 passing), `pnpm exec eslint src/pages/HITLTaskInstances/`,
`pnpm exec tsc -p tsconfig.app.json --noEmit`, and `prek run --files`
on the changed files.
<!-- Please keep an empty line for the release notes feature to work
properly. -->
^ Add meaningful description above
Read the [Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)
for more information.
In case of fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party
License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a
newsfragment file, named `{pr_number}.significant.rst` or
`{issue_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
Made with [Cursor](https://cursor.com)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
