shashbha14 commented on code in PR #66102:
URL: https://github.com/apache/airflow/pull/66102#discussion_r3190537527
##########
task-sdk/src/airflow/sdk/definitions/timetables/_cron.py:
##########
@@ -27,13 +27,26 @@
from pendulum.tz.timezone import FixedTimezone, Timezone
+CRON_PRESETS: dict[str, str] = {
+ "@hourly": "0 * * * *",
+ "@daily": "0 0 * * *",
+ "@weekly": "0 0 * * 0",
+ "@monthly": "0 0 1 * *",
+ "@quarterly": "0 0 1 */3 *",
+ "@yearly": "0 0 1 1 *",
+}
+
+
@attrs.define
class CronMixin:
"""Mixin to provide interface to work with croniter."""
expression: str
timezone: str | Timezone | FixedTimezone
+ def __attrs_post_init__(self) -> None:
+ self.expression = CRON_PRESETS.get(self.expression, self.expression)
Review Comment:
Added a three-line comment explaining the in-place normalisation and that
the preset string is intentionally lost after this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
