github-actions[bot] opened a new pull request, #66440:
URL: https://github.com/apache/airflow/pull/66440
* Fix remote_task_handler_kwargs passing handler params to RemoteLogIO
Split remote_task_handler_kwargs into handler-level params (max_bytes,
backup_count, delay) and IO-level params before the provider if/elif
chain. Handler params go to DEFAULT_LOGGING_CONFIG["handlers"]["task"],
IO params go to the RemoteLogIO constructor.
Previously all kwargs were passed to RemoteLogIO (causing TypeError
for attrs-based classes) and then reset to {}, so handler params
never reached FileTaskHandler.
closes: #58770
* Derive FileTaskHandler params dynamically via inspect instead of hardcoding
Address review feedback: use inspect.signature(FileTaskHandler.__init__)
to determine which remote_task_handler_kwargs belong to the file handler
vs the RemoteLogIO constructor. Remove dead _io_kwargs = {} reset lines.
* Move inspect and FileTaskHandler imports to top level
---------
(cherry picked from commit 823b86e006d30f118093e0ae76d25aecabd92ecb)
Co-authored-by: Sadha Chilukoori <[email protected]>
Co-authored-by: Sadha Chilukoori <[email protected]>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
