vincbeck opened a new pull request, #66487:
URL: https://github.com/apache/airflow/pull/66487
Storing the `allow_producer_teams` parameter on the `AssetModel` was bad
design decision. The same asset can be (and is expected to be) defined in
multiple Dags across different bundles. For example:
## Producer Dag (team1 bundle):
```
with DAG(
dag_id="example_producer_team1",
schedule="@once",
catchup=False,
):
task = EmptyOperator(task_id="produce_event",
outlets=[Asset("my_asset")])
chain(task)
```
## Consumer Dag (team2 bundle):
```
asset = Asset("my_asset", allow_producer_teams=["team1", "team2"])
with DAG(
dag_id="example_consumer_team2",
schedule=[asset],
catchup=False,
):
task = EmptyOperator(task_id="dummy_task")
```
The asset `my_asset` is referenced in both Dags. The producer does not
define `allow_producer_teams`, but the consumer does. Since each bundle is
processed independently, whichever bundle is parsed last overwrites the asset
row in the database. In other words, the producer bundle could wipe out the
consumer's `allow_producer_teams`.
Even though the asset is declared in multiple Dags, there is only one row in
the `asset` table. Storing `allow_producer_teams` there was not the right
choice because it is a consumer-side declaration: it controls which teams are
allowed to trigger this specific consumer, not a global property of the asset
itself.
Solution: Move `allow_producer_teams` to the `dag_schedule_asset_reference`
table, which represents the relationship between a consumer Dag and the asset
it schedules on.
<!-- SPDX-License-Identifier: Apache-2.0
https://www.apache.org/licenses/LICENSE-2.0 -->
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull
request.
Write a good git commit message following this guide:
http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the
documentation.
Feel free to ping (in general) for the review if you do not see reaction for
a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we
sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change below checkbox to `[X]` followed by the name of the tool, uncomment
the "Generated-by".
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name] following [the
guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
---
* Read the **[Pull Request
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
for more information. Note: commit author/co-author name and email in commits
become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License
Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment:
`{pr_number}.significant.rst`, in
[airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
You can add this file in a follow-up commit after the PR is created so you
know the PR number.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
