SameerMesiah97 commented on code in PR #66545: URL: https://github.com/apache/airflow/pull/66545#discussion_r3202937567
########## providers/amazon/docs/operators/s3_vectors.rst: ########## @@ -82,3 +82,11 @@ Reference --------- * `AWS boto3 Library Documentation for S3 Vectors <https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/s3vectors.html>`__ + +.. _howto/operator:S3VectorsPutVectorsOperator: + +Put Vectors +----------- + +To insert vectors into an Amazon S3 Vectors index, use +:class:`~airflow.providers.amazon.aws.operators.s3_vectors.S3VectorsPutVectorsOperator`. Review Comment: Same issue as in PR #66544. exampleinclude block is missing and this new section should be above 'Reference'. ########## providers/amazon/tests/unit/amazon/aws/operators/test_s3_vectors.py: ########## @@ -222,3 +223,31 @@ def test_execute(self): def test_template_fields(self): validate_template_fields(self.operator) + + +VECTORS = [{"key": "vec1", "data": {"float32": [0.1, 0.2, 0.3]}}] Review Comment: Since this is not being used by anything else besides `TestS3VectorsPutVectorsOperator`, perhaps it would be better to move it inside the test class you are adding? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
