SameerMesiah97 commented on code in PR #66561: URL: https://github.com/apache/airflow/pull/66561#discussion_r3213195643
########## task-sdk/tests/task_sdk/definitions/decorators/test_task_docstring.py: ########## @@ -0,0 +1,139 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +import pendulum +import pytest + +from airflow.sdk import dag, task + + Review Comment: Test coverage is solid. One additional edge case that may be worth covering is an already-dedented docstring to verify the transformation is effectively a no-op when no common indentation exists. Right now the tests only cover indented inputs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
